Co-worker/friend asking for a code review
I have a co-worker who I got to know through a mutual friend before we started working for the same company, although he s been working in the company for a year more than me, he was kinda relaxed and didn't take much responsibility and doesn't have a good reputation among his seniors,
I recently joined and worked hard to understand the product better from a technical standpoint and have a better hand at it now.
My colleague recently started developing a feature for the product and is almost set to completion, he now asks me to review his code before going through the formal code-review process, I can see a lot of flaws in his code already and I want him to learn, at the same time I strongly feel that I want to review his code formally just so that people know that I have helped him in coming up with a better code than what he already has, another reason is because I want him to work hard and not have everything spoon-fed to him.
Am I being too selfish here? How should I react to this ?
colleagues software-development
asked 1 hour ago
Sujith ShivaprakashSujith Shivaprakash
565
add a comment |
I have a co-worker who I got to know through a mutual friend before we started working for the same company, although he s been working in the company for a year more than me, he was kinda relaxed and didn't take much responsibility and doesn't have a good reputation among his seniors,
I recently joined and worked hard to understand the product better from a technical standpoint and have a better hand at it now.
My colleague recently started developing a feature for the product and is almost set to completion, he now asks me to review his code before going through the formal code-review process, I can see a lot of flaws in his code already and I want him to learn, at the same time I strongly feel that I want to review his code formally just so that people know that I have helped him in coming up with a better code than what he already has, another reason is because I want him to work hard and not have everything spoon-fed to him.
Am I being too selfish here? How should I react to this ?
colleagues software-development
asked 1 hour ago
Sujith ShivaprakashSujith Shivaprakash
565
1
"Am I being too selfish here?" - yes. "How should I react to this ?" - do your friend a favor and review his code.
– Joe Strazzere
1 hour ago
I suppose you're using git or some other version control software ? So if you're changing his code, you'll be doing changes under your name, anyone can see what is your work and what is his, no ?
– MlleMei
1 hour ago
Yes i am using git.
– Sujith Shivaprakash
1 hour ago
add a comment |
I have a co-worker who I got to know through a mutual friend before we started working for the same company, although he s been working in the company for a year more than me, he was kinda relaxed and didn't take much responsibility and doesn't have a good reputation among his seniors,
I recently joined and worked hard to understand the product better from a technical standpoint and have a better hand at it now.
My colleague recently started developing a feature for the product and is almost set to completion, he now asks me to review his code before going through the formal code-review process, I can see a lot of flaws in his code already and I want him to learn, at the same time I strongly feel that I want to review his code formally just so that people know that I have helped him in coming up with a better code than what he already has, another reason is because I want him to work hard and not have everything spoon-fed to him.
Am I being too selfish here? How should I react to this ?
colleagues software-development
asked 1 hour ago
Sujith ShivaprakashSujith Shivaprakash
565
I have a co-worker who I got to know through a mutual friend before we started working for the same company, although he s been working in the company for a year more than me, he was kinda relaxed and didn't take much responsibility and doesn't have a good reputation among his seniors,
I recently joined and worked hard to understand the product better from a technical standpoint and have a better hand at it now.
My colleague recently started developing a feature for the product and is almost set to completion, he now asks me to review his code before going through the formal code-review process, I can see a lot of flaws in his code already and I want him to learn, at the same time I strongly feel that I want to review his code formally just so that people know that I have helped him in coming up with a better code than what he already has, another reason is because I want him to work hard and not have everything spoon-fed to him.
Am I being too selfish here? How should I react to this ?
colleagues software-development
colleagues software-development
asked 1 hour ago
Sujith ShivaprakashSujith Shivaprakash
565
asked 1 hour ago
Sujith ShivaprakashSujith Shivaprakash
565
asked 1 hour ago
Sujith ShivaprakashSujith Shivaprakash
565
asked 1 hour ago
Sujith ShivaprakashSujith Shivaprakash
565
asked 1 hour ago
Sujith ShivaprakashSujith Shivaprakash
565
565
1
"Am I being too selfish here?" - yes. "How should I react to this ?" - do your friend a favor and review his code.
– Joe Strazzere
1 hour ago
I suppose you're using git or some other version control software ? So if you're changing his code, you'll be doing changes under your name, anyone can see what is your work and what is his, no ?
– MlleMei
1 hour ago
Yes i am using git.
– Sujith Shivaprakash
1 hour ago
add a comment |
1
"Am I being too selfish here?" - yes. "How should I react to this ?" - do your friend a favor and review his code.
– Joe Strazzere
1 hour ago
I suppose you're using git or some other version control software ? So if you're changing his code, you'll be doing changes under your name, anyone can see what is your work and what is his, no ?
– MlleMei
1 hour ago
Yes i am using git.
– Sujith Shivaprakash
1 hour ago
1
1
"Am I being too selfish here?" - yes. "How should I react to this ?" - do your friend a favor and review his code.
– Joe Strazzere
1 hour ago
"Am I being too selfish here?" - yes. "How should I react to this ?" - do your friend a favor and review his code.
– Joe Strazzere
1 hour ago
I suppose you're using git or some other version control software ? So if you're changing his code, you'll be doing changes under your name, anyone can see what is your work and what is his, no ?
– MlleMei
1 hour ago
I suppose you're using git or some other version control software ? So if you're changing his code, you'll be doing changes under your name, anyone can see what is your work and what is his, no ?
– MlleMei
1 hour ago
Yes i am using git.
– Sujith Shivaprakash
1 hour ago
Yes i am using git.
– Sujith Shivaprakash
1 hour ago
add a comment |
2 Answers
2
active
oldest
votes
I can see a lot of flaws in his code already and I want him to learn,
at the same time I strongly feel that I want to review his code
formally just so that people know that I have helped him in coming up
with a better code than what he already has, another reason is because
I want him to work hard and not have everything spoon-fed to him.
OK, there's a lot going on in that statement. Let me break it apart.
I can see a lot of flaws in his code already and I want him to learn
Are these flaws quantifiable, meaning would any other developer also see them as flaws, or is this your opinion? Are you being subjective or are you being objective in your analysis?
at the same time I strongly feel that I want to review his code
formally just so that people know that I have helped him in coming up
with a better code than what he already has
Is your goal to help your friend or is your goal to get some kind of credit for yourself for helping your friend? What's your true motivation?
another reason is because I want him to work hard and not have
everything spoon-fed to him
That's a bit condescending. How do you know that this person doesn't work hard? Are you the arbiter of who works hard and who doesn't? Do you make the determination of what level of effort constitutes hard work?
Is asking you to review his code analogous to being spoon-fed? Is he asking you to review it or to correct it? Is he asking you to do his work and research for him? If not, then he's not being spoon-fed.
answered 1 hour ago
joeqwertyjoeqwerty
1,502513
add a comment |
It all pivots around the question if your friend has the professional authority to ask you for this. If not (which i have the impression of) then it is a personal favor, i.e. off the clock, and off the record. Do not let the work assigned to you by your boss rest because of this task.
answered 1 hour ago
SaschaSascha
8,06421638
add a comment |
Your Answer
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "423"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
noCode: true, onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fworkplace.stackexchange.com%2fquestions%2f132419%2fco-worker-friend-asking-for-a-code-review%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
2 Answers
2
active
oldest
votes
2 Answers
2
active
oldest
votes
active
oldest
votes
active
oldest
votes
I can see a lot of flaws in his code already and I want him to learn,
at the same time I strongly feel that I want to review his code
formally just so that people know that I have helped him in coming up
with a better code than what he already has, another reason is because
I want him to work hard and not have everything spoon-fed to him.
OK, there's a lot going on in that statement. Let me break it apart.
I can see a lot of flaws in his code already and I want him to learn
Are these flaws quantifiable, meaning would any other developer also see them as flaws, or is this your opinion? Are you being subjective or are you being objective in your analysis?
at the same time I strongly feel that I want to review his code
formally just so that people know that I have helped him in coming up
with a better code than what he already has
Is your goal to help your friend or is your goal to get some kind of credit for yourself for helping your friend? What's your true motivation?
another reason is because I want him to work hard and not have
everything spoon-fed to him
That's a bit condescending. How do you know that this person doesn't work hard? Are you the arbiter of who works hard and who doesn't? Do you make the determination of what level of effort constitutes hard work?
Is asking you to review his code analogous to being spoon-fed? Is he asking you to review it or to correct it? Is he asking you to do his work and research for him? If not, then he's not being spoon-fed.
answered 1 hour ago
joeqwertyjoeqwerty
1,502513
add a comment |
I can see a lot of flaws in his code already and I want him to learn,
at the same time I strongly feel that I want to review his code
formally just so that people know that I have helped him in coming up
with a better code than what he already has, another reason is because
I want him to work hard and not have everything spoon-fed to him.
OK, there's a lot going on in that statement. Let me break it apart.
I can see a lot of flaws in his code already and I want him to learn
Are these flaws quantifiable, meaning would any other developer also see them as flaws, or is this your opinion? Are you being subjective or are you being objective in your analysis?
at the same time I strongly feel that I want to review his code
formally just so that people know that I have helped him in coming up
with a better code than what he already has
Is your goal to help your friend or is your goal to get some kind of credit for yourself for helping your friend? What's your true motivation?
another reason is because I want him to work hard and not have
everything spoon-fed to him
That's a bit condescending. How do you know that this person doesn't work hard? Are you the arbiter of who works hard and who doesn't? Do you make the determination of what level of effort constitutes hard work?
Is asking you to review his code analogous to being spoon-fed? Is he asking you to review it or to correct it? Is he asking you to do his work and research for him? If not, then he's not being spoon-fed.
answered 1 hour ago
joeqwertyjoeqwerty
1,502513
add a comment |
I can see a lot of flaws in his code already and I want him to learn,
at the same time I strongly feel that I want to review his code
formally just so that people know that I have helped him in coming up
with a better code than what he already has, another reason is because
I want him to work hard and not have everything spoon-fed to him.
OK, there's a lot going on in that statement. Let me break it apart.
I can see a lot of flaws in his code already and I want him to learn
Are these flaws quantifiable, meaning would any other developer also see them as flaws, or is this your opinion? Are you being subjective or are you being objective in your analysis?
at the same time I strongly feel that I want to review his code
formally just so that people know that I have helped him in coming up
with a better code than what he already has
Is your goal to help your friend or is your goal to get some kind of credit for yourself for helping your friend? What's your true motivation?
another reason is because I want him to work hard and not have
everything spoon-fed to him
That's a bit condescending. How do you know that this person doesn't work hard? Are you the arbiter of who works hard and who doesn't? Do you make the determination of what level of effort constitutes hard work?
Is asking you to review his code analogous to being spoon-fed? Is he asking you to review it or to correct it? Is he asking you to do his work and research for him? If not, then he's not being spoon-fed.
answered 1 hour ago
joeqwertyjoeqwerty
1,502513
I can see a lot of flaws in his code already and I want him to learn,
at the same time I strongly feel that I want to review his code
formally just so that people know that I have helped him in coming up
with a better code than what he already has, another reason is because
I want him to work hard and not have everything spoon-fed to him.
OK, there's a lot going on in that statement. Let me break it apart.
I can see a lot of flaws in his code already and I want him to learn
Are these flaws quantifiable, meaning would any other developer also see them as flaws, or is this your opinion? Are you being subjective or are you being objective in your analysis?
at the same time I strongly feel that I want to review his code
formally just so that people know that I have helped him in coming up
with a better code than what he already has
Is your goal to help your friend or is your goal to get some kind of credit for yourself for helping your friend? What's your true motivation?
another reason is because I want him to work hard and not have
everything spoon-fed to him
That's a bit condescending. How do you know that this person doesn't work hard? Are you the arbiter of who works hard and who doesn't? Do you make the determination of what level of effort constitutes hard work?
Is asking you to review his code analogous to being spoon-fed? Is he asking you to review it or to correct it? Is he asking you to do his work and research for him? If not, then he's not being spoon-fed.
answered 1 hour ago
joeqwertyjoeqwerty
1,502513
answered 1 hour ago
joeqwertyjoeqwerty
1,502513
answered 1 hour ago
joeqwertyjoeqwerty
1,502513
answered 1 hour ago
joeqwertyjoeqwerty
1,502513
1,502513
add a comment |
add a comment |
It all pivots around the question if your friend has the professional authority to ask you for this. If not (which i have the impression of) then it is a personal favor, i.e. off the clock, and off the record. Do not let the work assigned to you by your boss rest because of this task.
answered 1 hour ago
SaschaSascha
8,06421638
add a comment |
It all pivots around the question if your friend has the professional authority to ask you for this. If not (which i have the impression of) then it is a personal favor, i.e. off the clock, and off the record. Do not let the work assigned to you by your boss rest because of this task.
answered 1 hour ago
SaschaSascha
8,06421638
add a comment |
It all pivots around the question if your friend has the professional authority to ask you for this. If not (which i have the impression of) then it is a personal favor, i.e. off the clock, and off the record. Do not let the work assigned to you by your boss rest because of this task.
answered 1 hour ago
SaschaSascha
8,06421638
It all pivots around the question if your friend has the professional authority to ask you for this. If not (which i have the impression of) then it is a personal favor, i.e. off the clock, and off the record. Do not let the work assigned to you by your boss rest because of this task.
answered 1 hour ago
SaschaSascha
8,06421638
answered 1 hour ago
SaschaSascha
8,06421638
answered 1 hour ago
SaschaSascha
8,06421638
answered 1 hour ago
SaschaSascha
8,06421638
8,06421638
add a comment |
add a comment |
Thanks for contributing an answer to The Workplace Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fworkplace.stackexchange.com%2fquestions%2f132419%2fco-worker-friend-asking-for-a-code-review%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
1
"Am I being too selfish here?" - yes. "How should I react to this ?" - do your friend a favor and review his code.
– Joe Strazzere
1 hour ago
I suppose you're using git or some other version control software ? So if you're changing his code, you'll be doing changes under your name, anyone can see what is your work and what is his, no ?
– MlleMei
1 hour ago
Yes i am using git.
– Sujith Shivaprakash
1 hour ago